[webkit-reviews] review granted: [Bug 59721] REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs : [Attachment 91619] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 59721: REGRESSION (WebKit2): (Mac) Selection is gone after switching tabs
https://bugs.webkit.org/show_bug.cgi?id=59721

Attachment 91619: Patch
https://bugs.webkit.org/attachment.cgi?id=91619&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91619&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.h:45
> +- (BOOL)maintainsInactiveSelection;

Does this need to be in the header file? Normally, we don’t have to declare
methods if we’re just overriding something in NSView. We only need to put the
method in the header if it’s a new method that some other class is going to
call.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:318
> +    if (![self maintainsInactiveSelection])
> +	   _data->_page->clearSelection();

Is there a good reason to call maintainsInactiveSelection here? It’s just a
function that always returns NO.

Do we expect people to make subclasses of WKView and override the
maintainsActiveSelection method?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:564
> +- (BOOL)maintainsInactiveSelection
> +{
> +    return false;
> +}

For BOOL it’s YES and NO. The values false and true are of type bool.