[webkit-reviews] review granted: [Bug 59776] Sometimes WebKit2 pauses during launch due to waiting for the first render : [Attachment 91635] first patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Stephanie Lewis <slewis at apple.com>'s
request for review:
Bug 59776: Sometimes WebKit2 pauses during launch due to waiting for the first
render
https://bugs.webkit.org/show_bug.cgi?id=59776

Attachment 91635: first patch
https://bugs.webkit.org/attachment.cgi?id=91635&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91635&action=review

>> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:80
>> +	    if(!m_hasReceivedFirstUpdate)
> 
> Missing space before ( in if(  [whitespace/parens] [5]

I agree with the style bot.

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp:188
> +    else if (!m_hasReceivedFirstUpdate)
> +	   m_hasReceivedFirstUpdate = true;

No need for the if statement here. You don’t have to check a boolean is false
before setting it to true.

> Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h:102
> +    // For the first draw, don't draw anything until the WebProcess has sent
over the bits.

This comment says “for the first draw”, but the code affects more than just the
first draw, right?