[webkit-reviews] review granted: [Bug 59779] Fix IR->SR typo in enum value (and resulting style fails) : [Attachment 91638] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 29 08:45:15 PDT 2011
Ojan Vafai <ojan at chromium.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 59779: Fix IR->SR typo in enum value (and resulting style fails)
https://bugs.webkit.org/show_bug.cgi?id=59779
Attachment 91638: Patch
https://bugs.webkit.org/attachment.cgi?id=91638&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91638&action=review
Code change looks fine. Please write a layout test if it's possible. If it's
not possible, feel free to remark cq?.
> Source/WebCore/css/CSSPrimitiveValueMappings.h:2918
> + case SR_AUTO:
> + m_value.ident = CSSValueAuto;
> + break;
> + case SR_OPTIMIZESPEED:
Is it not possible to write a layout test that tests these values? It would be
nice to see a test go green here if possible.
More information about the webkit-reviews
mailing list