[webkit-reviews] review granted: [Bug 59788] Web Inspector: add "open link in new tab" action into the network and resources panels. : [Attachment 91655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 29 02:33:43 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 59788: Web Inspector: add "open link in new tab" action into the network
and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=59788

Attachment 91655: Patch
https://bugs.webkit.org/attachment.cgi?id=91655&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91655&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1018
> +		  
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitle
s() ? "Save entry as HAR" : "Save Entry as HAR"),
this._exportResource.bind(this, resource));

Can you encapsulate WebInspector.useLowerCaseMenuTitles() logic in UIString to
avoid recurring ternary ifs ?


More information about the webkit-reviews mailing list