[webkit-reviews] review denied: [Bug 58100] 1px box-shadow looks ugly : [Attachment 91539] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 58100: 1px box-shadow looks ugly
https://bugs.webkit.org/show_bug.cgi?id=58100

Attachment 91539: Patch
https://bugs.webkit.org/attachment.cgi?id=91539&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91539&action=review

Can you please check if the pixel results for feDropShadow changed (they
should) and update them? They are located at
LayoutTests/svg/filter/feDropShadow.svg and LayoutTests/dynamic-updates/

r- for the test and the and the missing result updates. The fix itself looks
good to me. If I should be wrong with tests just add a comment.

> LayoutTests/fast/box-shadow/single-pixel-shadow.html:15
> +	 -webkit-transform-origin: -1px -1px;
> +	 -webkit-transform: scale(20);

Do you really want a pixelation here? On SVG we try to avoid this and transform
all affected objects to devicespace and apply shadows afterwards. So we always
have a goof looking shadow. This definitely does not belong to this big. But if
it gets changed in the future, the text would be useless. Have you checked what
Firefox or Opera are doing? But I don't have an idea how to make a pixel with
it. What about canvas? Is canvas using shadow? If you draw a shadow on canvas
it should be pixelated on scaling, also in the future, no?