[webkit-reviews] review denied: [Bug 59761] fix pretty_patch_available and wdiff_available : [Attachment 91588] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 59761: fix pretty_patch_available and wdiff_available
https://bugs.webkit.org/show_bug.cgi?id=59761

Attachment 91588: Patch
https://bugs.webkit.org/attachment.cgi?id=91588&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91588&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:211
> +    def check_wdiff(self, logging=True):
> +	   return False

What is the logging param for?

> Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py:110
> -	   result = self._check_wdiff_install() and result
> +	   result = self.check_wdiff() and result

I think mac can use wdiff too.