[webkit-reviews] review granted: [Bug 59760] Right-clicking on a Flash movie in an iframe shows the browser context menu : [Attachment 91587] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 28 16:40:02 PDT 2011
Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 59760: Right-clicking on a Flash movie in an iframe shows the browser
context menu
https://bugs.webkit.org/show_bug.cgi?id=59760
Attachment 91587: Patch
https://bugs.webkit.org/attachment.cgi?id=91587&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91587&action=review
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:956
> + return handleContextMenuEvent(platformMouseEvent, page);
Is it really OK to ignore the result of “handled” entirely here? Not || it in?
Is it correct to return false if the mouse press event was handled, but not the
context menu event?
More information about the webkit-reviews
mailing list