[webkit-reviews] review granted: [Bug 59750] fast/harness/results.html failing in some configurations : [Attachment 91575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 16:38:23 PDT 2011


Darin Adler <darin at apple.com> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 59750: fast/harness/results.html failing in some configurations
https://bugs.webkit.org/show_bug.cgi?id=59750

Attachment 91575: Patch
https://bugs.webkit.org/attachment.cgi?id=91575&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91575&action=review

> LayoutTests/fast/harness/resources/results-test.js:318
> +	   // Use a regexp to match windows and unix-style paths.

Never heard of windows and unix, maybe you mean Windows and Unix? ;-)

> LayoutTests/fast/harness/resources/results-test.js:319
> +	   var expectedRegExp = new RegExp('file.*' + results.layout_tests_dir
+ '/fullscreen/full-screen-api.html');

Does this need a ^ and a $, or does the exec function only match the entire
URL?


More information about the webkit-reviews mailing list