[webkit-reviews] review granted: [Bug 59759] Overflow:scroll regions with overlay scrollbars show full thumb instead of just a track when there is nothing to scroll to : [Attachment 91586] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 16:31:31 PDT 2011


Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 59759: Overflow:scroll regions with overlay scrollbars show full thumb
instead of just a track when there is nothing to scroll to
https://bugs.webkit.org/show_bug.cgi?id=59759

Attachment 91586: Patch
https://bugs.webkit.org/attachment.cgi?id=91586&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91586&action=review

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:472
> +    float proportion = visibleSize != totalSize ? (visibleSize - overhang) /
totalSize : 0;

I kind of wish you used "<" here instead of "!=".


More information about the webkit-reviews mailing list