[webkit-reviews] review denied: [Bug 59741] Chromium Mac: Add scrollbar overlay drawing functions : [Attachment 91562] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 28 16:17:31 PDT 2011
Mihai Parparita <mihaip at chromium.org> has denied Sailesh Agrawal
<sail at chromium.org>'s request for review:
Bug 59741: Chromium Mac: Add scrollbar overlay drawing functions
https://bugs.webkit.org/show_bug.cgi?id=59741
Attachment 91562: Patch
https://bugs.webkit.org/attachment.cgi?id=91562&action=review
------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91562&action=review
> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:36
> +// This file contains utilities to draw overlay scrollbars. There are no
plublic
s/plublic/public/.
> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesMac.mm:106
> +static Class LookUpNSScrollerImpClass() {
There's a quite a few WebKit style issues here:
- opening brace should be on its own line for function definitions.
- The first letter does not need to be capitalized.
- Indents should be 4 spaces.
More information about the webkit-reviews
mailing list