[webkit-reviews] review requested: [Bug 59755] AXObjectCache::attachWrapper() over-retains an AccessibilityObjectWrapper : [Attachment 91580] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 59755: AXObjectCache::attachWrapper() over-retains an
AccessibilityObjectWrapper
https://bugs.webkit.org/show_bug.cgi?id=59755

Attachment 91580: Patch
https://bugs.webkit.org/attachment.cgi?id=91580&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Previously, AXObjectCache::attachWrapper over-retained each
AccessibilityObjectWrapper it created, which is why
AXObjectCache::detachWrapper() contained an extra -release.

* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::detachWrapper): Removed extra -release.
(WebCore::AXObjectCache::attachWrapper): Because setWrapper()
assigns to a RetainPtr<> instance variable, it doesn't need a +1
retained object passed in.  Fix the leak by using a RetainPtr<>
for the AccessibilityObjectWrapper.
---
 2 files changed, 19 insertions(+), 2 deletions(-)