[webkit-reviews] review granted: [Bug 59746] WebKit2: Frequent crashes in acceptsFirstMouse : [Attachment 91569] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 15:53:40 PDT 2011


Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 59746: WebKit2: Frequent crashes in acceptsFirstMouse
https://bugs.webkit.org/show_bug.cgi?id=59746

Attachment 91569: proposed fix
https://bugs.webkit.org/attachment.cgi?id=91569&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91569&action=review

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:186
> +	   location = 0;
> +	   length = 0;
> +	   return;

Shouldn't location be NSNotFound here?

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:194
> +	   location = 0;

Ditto


More information about the webkit-reviews mailing list