[webkit-reviews] review denied: [Bug 59638] [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors : [Attachment 91555] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 15:41:20 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has denied Chang Shu <cshu at webkit.org>'s
request for review:
Bug 59638: [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

Attachment 91555: fix patch
https://bugs.webkit.org/attachment.cgi?id=91555&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
You should not use the opaque type from the C API in the C++ Qt API. So at
least you should write a nice wrapper for PageGroup to make this feature.

But I actually don't see a use case for exposing the page group so I think it
should be handled internally for our APIs. If you don't agree, please add a
relevant test for the use case of multiple page group.


More information about the webkit-reviews mailing list