[webkit-reviews] review granted: [Bug 59134] WebKit2: Support docked mode for Web Inspector : [Attachment 91392] [PATCH] Mac Fix v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 15:00:47 PDT 2011


Timothy Hatcher <timothy at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 59134: WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134

Attachment 91392: [PATCH] Mac Fix v1
https://bugs.webkit.org/attachment.cgi?id=91392&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91392&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:92
> +- (NSInteger)tag
> +{
> +    return WKInspectorViewTag;
> +}

You don't need to do this as a subclass. You can call setTag: on the normal
WKView.


More information about the webkit-reviews mailing list