[webkit-reviews] review granted: [Bug 59740] DFG JIT - Unify GPRReg & RegisterID : [Attachment 91559] The patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 59740: DFG JIT - Unify GPRReg & RegisterID
https://bugs.webkit.org/show_bug.cgi?id=59740

Attachment 91559: The patch
https://bugs.webkit.org/attachment.cgi?id=91559&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91559&action=review

Fix the x86 specific badness

> Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.h:173
> +	   GPRReg canTrample = (preserve == X86Registers::eax) ?
X86Registers::edx : X86Registers::eax;

Ye cannae do that captain!!!!!

> Source/JavaScriptCore/dfg/DFGNonSpeculativeJIT.h:187
> +	   GPRReg canTrample = (preserve == X86Registers::eax) ?
X86Registers::edx : X86Registers::eax;

Ach no!!