[webkit-reviews] review granted: [Bug 59668] [chromium] Compute compositor fps value and history using the frameBegin timestamp : [Attachment 91508] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 59668: [chromium] Compute compositor fps value and history using the
frameBegin timestamp
https://bugs.webkit.org/show_bug.cgi?id=59668

Attachment 91508: Patch
https://bugs.webkit.org/attachment.cgi?id=91508&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91508&action=review

R=me, but please fix nits before committing.

> Source/WebCore/ChangeLog:9
> +	   beginning of the frame rather than the time we call swapBuffers.
When scheudling is

oops: scheudling

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:196
> +    // This value is currently inaccessible because it is up in
RenderWidget.

I think you mean Chromium's RenderWidget (render_widget.cc), but this could be
confused with WebCore::RenderWidget.