[webkit-reviews] review granted: [Bug 19428] [Gtk] Split JSC and WebCore builds : [Attachment 91424] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 19428: [Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Attachment 91424: Patch
https://bugs.webkit.org/attachment.cgi?id=91424&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91424&action=review

> GNUmakefile.am:-130
> -# Convenience libraries
> -noinst_LTLIBRARIES += \
> -	libJavaScriptCore.la
> -
> -nodist_EXTRA_libJavaScriptCore_la_SOURCES = \

I'm really happy to see this stuff move out of the main GNUmakefile.am finally!


> Source/JavaScriptCore/GNUmakefile.am:36
>
+libjavascriptcoregtk_ at WEBKITGTK_API_MAJOR_VERSION@_ at WEBKITGTK_API_MINOR_VERSIO
N at _la_CFLAGS = \
> +	-fstrict-aliasing \
> +	-O3 \

Seems like the optimization level should be global across all libraries. That
is unrelated to this patch though.

> Source/JavaScriptCore/GNUmakefile.am:112
> +	$(AM_V_GEN)cp -f Programs/jsc- at WEBKITGTK_API_MAJOR_VERSION@$(EXEEXT)
Programs/jsc$(EXEEXT)

A symlink might be better here?