[webkit-reviews] review granted: [Bug 19428] [Gtk] Split JSC and WebCore builds : [Attachment 91505] pkgconfig.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 11:55:58 PDT 2011


Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 19428: [Gtk] Split JSC and WebCore builds
https://bugs.webkit.org/show_bug.cgi?id=19428

Attachment 91505: pkgconfig.diff
https://bugs.webkit.org/attachment.cgi?id=91505&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91505&action=review

> Source/WebKit/gtk/GNUmakefile.am:584
>      
$(top_builddir)/Source/WebKit/gtk/@WEBKITGTK_PC_NAME at -@WEBKITGTK_API_VERSION at .p
c \
> +    
$(top_builddir)/Source/WebKit/gtk/javascriptcoregtk- at WEBKITGTK_API_VERSION@.pc
>      
$(top_builddir)/Source/WebKit/gtk/org.webkitgtk- at WEBKITGTK_API_VERSION@.gschema
.xml \

Pretty sure you're missing a \ at the end of this line.


More information about the webkit-reviews mailing list