[webkit-reviews] review denied: [Bug 59699] Global object is recreated on teardown, for no good reason : [Attachment 91486] Possible fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied  review:
Bug 59699: Global object is recreated on teardown, for no good reason
https://bugs.webkit.org/show_bug.cgi?id=59699

Attachment 91486: Possible fix
https://bugs.webkit.org/attachment.cgi?id=91486&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think this patch would crash, because setWindow(JSGlobalData&, JSDOMWindow*)
assumes the window is not NULL.

It might work to change setWindow(JSGlobalData&, JSDOMWindow*) to use jsNull()
as the window shell's prototype if the JSDOMWindow* is NULL, or you could just
change setWindow(JSGlobalData&, JSDOMWindow*) to take an explicit prototype
argument.