[webkit-reviews] review granted: [Bug 59715] [GTK] Click counting logic should be shared between WebKit1 and WebKit2 : [Attachment 91519] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 11:28:15 PDT 2011


Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 59715: [GTK] Click counting logic should be shared between WebKit1 and
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59715

Attachment 91519: Patch
https://bugs.webkit.org/attachment.cgi?id=91519&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91519&action=review

Great stuff!

> Source/WebCore/platform/gtk/GtkClickCounter.cpp:23
> +#include <gdk/gdk.h>

I suppose this comes for free from gtk.h

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:-339
> -

I actually object to this line being removed! Buurn.


More information about the webkit-reviews mailing list