[webkit-reviews] review granted: [Bug 59000] Web Inspector: [protocol] Evaluate should expose thrown exception value : [Attachment 91511] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 59000: Web Inspector: [protocol] Evaluate should expose thrown exception
value
https://bugs.webkit.org/show_bug.cgi?id=59000

Attachment 91511: Patch
https://bugs.webkit.org/attachment.cgi?id=91511&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91511&action=review

> LayoutTests/inspector/protocol/runtime-agent-expected.txt:26
> +	   wasThrown : false

Could you make this optional?

> Source/WebCore/inspector/InjectedScript.cpp:214
> +	   *errorString = "Internal error";

Could you add more details to this message?

> Source/WebCore/inspector/InjectedScript.cpp:223
> +	   *errorString = "Internal error";

ditto

> Source/WebCore/inspector/Inspector.json:214
> +		       { "name": "valueWasThrown", "type": "boolean",
"optional": true, "description": "True if exception was thrown on attempt to
get the property value, in that case the value propery will contain thrown
value." },

wasThrown

> Source/WebCore/inspector/front-end/ConsoleView.js:363
> +	       if (!result || wasThrown)

is this check needed?