[webkit-reviews] review granted: [Bug 59674] Add way to install testapi in production builds : [Attachment 91496] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 59674: Add way to install testapi in production builds
https://bugs.webkit.org/show_bug.cgi?id=59674

Attachment 91496: Patch
https://bugs.webkit.org/attachment.cgi?id=91496&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91496&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   Remove in project build settings and add missing configuration
files.

Nit: "in project" should be hyphenated as "in-project" since it's used as an
adjective.

You should also note that you're adding CompilerVersion.xcconfig here since
that is just an additional clean-up step.  (It should also be done for the
other 4 projects that added it.)