[webkit-reviews] review denied: [Bug 59697] [Soup] does not load css stylesheets without content-type : [Attachment 91489] patch v1.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 07:47:01 PDT 2011


Gustavo Noronha (kov) <gns at gnome.org> has denied arno. <arno at renevier.net>'s
request for review:
Bug 59697: [Soup] does not load css stylesheets without content-type
https://bugs.webkit.org/show_bug.cgi?id=59697

Attachment 91489: patch v1.1
https://bugs.webkit.org/attachment.cgi?id=91489&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91489&action=review

Just a style nit.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:345
> +		       soup_header_g_string_append_param(str, (const char*)
key, (const char*) value);

This should use C++-style casts like this: static_cast<const char*>(key).


More information about the webkit-reviews mailing list