[webkit-reviews] review granted: [Bug 59616] Web Inspector: add ResourceTreeModel test for initial load. : [Attachment 91483] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 28 07:02:24 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 59616: Web Inspector: add ResourceTreeModel test for initial load.
https://bugs.webkit.org/show_bug.cgi?id=59616

Attachment 91483: Patch
https://bugs.webkit.org/attachment.cgi?id=91483&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91483&action=review

>
LayoutTests/http/tests/inspector/resource-tree/resource-tree-frame-navigate.htm
l:53
> +Tests resource tree model on iframe navigation.

Please describe what should be treated as a correct result, it's hard to guess
it from the test output.

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:90
> +	       this._subframes[frame.parentId] = subframes;

Is it possible that the frame is the main frame?


More information about the webkit-reviews mailing list