[webkit-reviews] review granted: [Bug 48074] [Cairo] Text underline is not shadowed when text-shadow is enabled : [Attachment 91327] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 48074: [Cairo] Text underline is not shadowed when text-shadow is enabled
https://bugs.webkit.org/show_bug.cgi?id=48074

Attachment 91327: Patch
https://bugs.webkit.org/attachment.cgi?id=91327&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91327&action=review

> LayoutTests/ChangeLog:12
> +	   * platform/gtk/fast/text/stroking-decorations-expected.checksum:
> +	   * platform/gtk/fast/text/stroking-decorations-expected.png:

At least the checksum is missing. And I can't see the image with the review
tool :-(. But that is not your problem.

> Source/WebCore/ChangeLog:8
> +	   Use ShadowContext to enable shadows for text underlines. Also remove
quite a bit

You mean ContextShadow

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:443
> +	       distance = (piFloat * hRadius) / 2.0;

2 or 2.f if you use float. But 2 shouldn't be a problem here.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:445
> +	       distance = (piFloat * sqrtf((hRadius * hRadius + vRadius *
vRadius) / 2.0)) / 2.0;

Ditto.