[webkit-reviews] review denied: [Bug 58905] [Qt][Texmap] Do not create a texture if it will not be used. : [Attachment 91281] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 20:10:41 PDT 2011


Antonio Gomes <tonikitoo at webkit.org> has denied Young Han Lee
<joybro at company100.net>'s request for review:
Bug 58905: [Qt][Texmap] Do not create a texture if it will not be used.
https://bugs.webkit.org/show_bug.cgi?id=58905

Attachment 91281: Patch
https://bugs.webkit.org/attachment.cgi?id=91281&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91281&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:176
> +    inline bool haveContent() const

it should be named hasContent, or something better and more descriptive.


More information about the webkit-reviews mailing list