[webkit-reviews] review denied: [Bug 59369] Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel test to text-based test : [Attachment 91407] Patch

Wed Apr 27 19:07:57 PDT 2011

Ryosuke Niwa <rniwa at webkit.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 59369: Convert LayoutTests/fast/events/mouseout-dead-node.html from pixel
test to text-based test
https://bugs.webkit.org/show_bug.cgi?id=59369

Attachment 91407: Patch
https://bugs.webkit.org/attachment.cgi?id=91407&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91407&action=review

> LayoutTests/fast/events/mouseout-dead-node.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

Please use HTML5 style <!DOCTYPE html>

> LayoutTests/fast/events/mouseout-dead-node.html:11
> +<div onmouseout='testFailed("mouseout")' 
onmouseover='document.getElementById("d0").innerHTML ="you should see PASS
below"'>

I would have done: this.parent.innerHTML="~~".

> LayoutTests/fast/events/mouseout-dead-node.html:33
> +if (!window.eventSender)
> +    return;

This won't work. I guess you'll have to put everything in an if clause.