[webkit-reviews] review granted: [Bug 59664] Fix OwnPtr strict issues in chromium linux build : [Attachment 91395] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 18:27:37 PDT 2011


Adam Barth <abarth at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 59664: Fix OwnPtr strict issues in chromium linux build
https://bugs.webkit.org/show_bug.cgi?id=59664

Attachment 91395: Patch
https://bugs.webkit.org/attachment.cgi?id=91395&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91395&action=review

> Source/WebKit/chromium/src/WebImageDecoder.cpp:115
> -    OwnPtr<NativeImageSkia>image(frameBuffer->asNewNativeImage());
> +    OwnPtr<NativeImageSkia>
image(adoptPtr(frameBuffer->asNewNativeImage()));

We usually prefer the = form of the constructor.


More information about the webkit-reviews mailing list