[webkit-reviews] review granted: [Bug 59226] Should have an easy way to construct starting BidiStatus for a paragraph root : [Attachment 90795] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 16:40:56 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 59226: Should have an easy way to construct starting BidiStatus for a
paragraph root
https://bugs.webkit.org/show_bug.cgi?id=59226

Attachment 90795: Patch
https://bugs.webkit.org/attachment.cgi?id=90795&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90795&action=review

> Source/WebCore/platform/graphics/GraphicsContext.cpp:418
> +	   bool isRTL = bidiRun->level() % 2;
> +	   subrun.setDirection(isRTL ? RTL : LTR);

I'm not sure if this local variable is anyway helpful.
subrun.setDirection(bidiRun->level() % 2? RTL : LTR)
is clear enough to me.


More information about the webkit-reviews mailing list