[webkit-reviews] review denied: [Bug 59601] [GTK] Do not initialize wep application database if it was disabled at configure time. : [Attachment 91270] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Alexandre Mazari
<scaroo at gmail.com>'s request for review:
Bug 59601: [GTK] Do not initialize wep application database if it was disabled
at configure time.
https://bugs.webkit.org/show_bug.cgi?id=59601

Attachment 91270: Patch
https://bugs.webkit.org/attachment.cgi?id=91270&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91270&action=review

Very nice. One small suggestion below.

> Source/WebKit/gtk/webkit/webkitglobals.cpp:271
>      gchar* databaseDirectory = g_build_filename(g_get_user_data_dir(),
"webkit", "databases", NULL);
>      webkit_set_web_database_directory_path(databaseDirectory);
>      WebCore::cacheStorage().setCacheDirectory(databaseDirectory);
>  
>      g_free(databaseDirectory);

Please switch to using GOwnPtr for databaseDirectory:

GOwnPtr<gchar> databaseDirectory = g_build_filename(g_get_user_data_dir(),
"webkit", "databases", NULL);
webkit_set_web_database_directory_path(databaseDirectory.get());
WebCore::cacheStorage().setCacheDirectory(databaseDirectory.get());