[webkit-reviews] review requested: [Bug 58420] String operator+ reallocates unnecessary when concatting > 2 strings : [Attachment 91328] Patch v6

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 58420: String operator+ reallocates unnecessary when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420

Attachment 91328: Patch v6
https://bugs.webkit.org/attachment.cgi?id=91328&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Adressed Maciejs comments.
I've tried a simple microbenchmark, concatting two Strings, several thousands
of times, and couldn't measure any difference between the new and the old
method. Though that's not really accurate, but I think we won't see any
performance regressions for the simple two string concat case, and only wins
for n>2 concats.

Could we verify the theory that nothing changed using a post-commit PLT run
from Apple?
P.S. I bet we'll need a Patch v7 as I need to adjust win symbol export table
after I get the EWS results.