[webkit-reviews] review granted: [Bug 58113] [Refactoring] DocumentMarkerController::MarkerMapVectorPair should be replaced with a list of some class. : [Attachment 91309] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 10:42:14 PDT 2011


Tony Chang <tony at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 58113: [Refactoring] DocumentMarkerController::MarkerMapVectorPair should
be replaced with a list of some class.
https://bugs.webkit.org/show_bug.cgi?id=58113

Attachment 91309: Patch
https://bugs.webkit.org/attachment.cgi?id=91309&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91309&action=review

> Source/WebCore/dom/DocumentMarkerController.cpp:457
> +// XXX: something wrong

Did you mean to remove this?

> Source/WebCore/dom/DocumentMarkerController.cpp:466
> +    unsigned markerCount = list->size();

Nit: size_t


More information about the webkit-reviews mailing list