[webkit-reviews] review requested: [Bug 55901] [Qt] Fix the error code for media resource failures when using QtMobility : [Attachment 91298] fix the patch according to the qtmobility change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 27 09:21:38 PDT 2011


yi shen <yi.4.shen at nokia.com> has asked  for review:
Bug 55901: [Qt] Fix the error code for media resource failures when using
QtMobility
https://bugs.webkit.org/show_bug.cgi?id=55901

Attachment 91298: fix the patch according to the qtmobility change
https://bugs.webkit.org/attachment.cgi?id=91298&action=review

------- Additional Comments from yi shen <yi.4.shen at nokia.com>
With the QtMobility 1.2.0, it can send out QMediaPlayer::ResourceError after
QMediaPlayer::InvalidMedia for resource issue. So I made a little bit change
for it in this new patch.

Also, I noticed that all the media tests are disabled in
https://bugs.webkit.org/show_bug.cgi?id=57983, so I just tested the related
layouttest(including tests under LayoutTest/media and LayoutTest/fast/media) on
my environment.


More information about the webkit-reviews mailing list