[webkit-reviews] review granted: [Bug 59545] sherrifbot create-bug shouldn't assign bugs to webkit.review.bot : [Attachment 91240] Patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 59545: sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
https://bugs.webkit.org/show_bug.cgi?id=59545

Attachment 91240: Patch
https://bugs.webkit.org/attachment.cgi?id=91240&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91240&action=review

> Tools/Scripts/webkitpy/common/config/committers.py:391
> +	       if contributor.full_name and contributor.full_name == name:

Why the check if contributor.full_name is non-empty? Presumably the name
argument will be non-empty, so the equality check should take care of that.

> Tools/Scripts/webkitpy/common/config/committers.py:400
> +	       if contributor.irc_nickname and contributor.irc_nickname ==
irc_nickname:

Ditto here.

> Tools/Scripts/webkitpy/common/config/committers.py:404
> +    def contributor_by_email(self, email):

Now that you have this, perhaps the committer_by_email call in the whois
command should also be changed to support contributors?