[webkit-reviews] review granted: [Bug 59590] Web Inspector: clicking bookmarklet multiplies resources panel entries. : [Attachment 91273] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 59590: Web Inspector: clicking bookmarklet multiplies resources panel
entries.
https://bugs.webkit.org/show_bug.cgi?id=59590

Attachment 91273: Patch
https://bugs.webkit.org/attachment.cgi?id=91273&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91273&action=review

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:136
>	       WebInspector.mainResource = this.resourceForURL(frame.url);

Can you swap this line with the one above?

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1017
> +	   this._treeElementForResource[resource.url] = resourceTreeElement;

I'd rather move it to the beginning of the method.

> Source/WebCore/inspector/front-end/ResourcesPanel.js:1022
> +	   WebInspector.BaseStorageTreeElement.prototype.removeChildren.call();


call(this)