[webkit-reviews] review granted: [Bug 58996] Web Inspector: [protocol] Paused event should expose exception value that caused it : [Attachment 91246] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 58996: Web Inspector: [protocol] Paused event should expose exception value
that caused it
https://bugs.webkit.org/show_bug.cgi?id=58996

Attachment 91246: Patch
https://bugs.webkit.org/attachment.cgi?id=91246&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91246&action=review

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:221
> +	   contextScope.set(new
v8::Context::Scope(v8::Debug::GetDebugContext()));

Poor merge?

> Source/WebCore/bindings/v8/ScriptDebugServer.cpp:341
> +		   if (!exceptionGetterValue.IsEmpty() &&
exceptionGetterValue->IsFunction()) {

Could you put ASSERT here?