[webkit-reviews] review requested: [Bug 59580] Extract KeyboardEventHandler from EventHandler : [Attachment 91229] work in progress

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 59580: Extract KeyboardEventHandler from EventHandler
https://bugs.webkit.org/show_bug.cgi?id=59580

Attachment 91229: work in progress
https://bugs.webkit.org/attachment.cgi?id=91229&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
Here's a work in progress patch (r? only because I want EWS to find build
errors)

Sam & Alexey, could you tell me what CurrentEventScope is trying to do in
EventHandlerMac.mm?  I removed EventHandler::keyEvent(NSEvent*) and replaced
call sites in WebHTMLView.mm by keyEvent(PlatformKeyboardEvent(event)) but I
didn't add CurrentEventScope in those places.  Should I be adding them?  As far
as I looked at the definition of CurrentEventScope, they only seem to have a
retain pointer for NSEvent which makes me think that the code is there only to
resolve some binding issues between C++ and Objective-C but I'm entirely sure.