[webkit-reviews] review granted: [Bug 58301] Extract map from port to builder name. : [Attachment 91203] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 18:32:06 PDT 2011


Eric Seidel <eric at webkit.org> has granted James Kozianski <koz at chromium.org>'s
request for review:
Bug 58301: Extract map from port to builder name.
https://bugs.webkit.org/show_bug.cgi?id=58301

Attachment 91203: Patch
https://bugs.webkit.org/attachment.cgi?id=91203&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Still awesome.	Ideally we would unittest get_path_from_name  (Which probably
should be an _ function anyway.... and I think WebKit generaly avoids using
"get" in function names).


More information about the webkit-reviews mailing list