[webkit-reviews] review denied: [Bug 50999] Supports Unicode variation selector : [Attachment 76844] Patch V0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 18:09:17 PDT 2011


Kent Tamura <tkent at chromium.org> has denied Kenichi Ishibashi
<bashi at google.com>'s request for review:
Bug 50999: Supports Unicode variation selector
https://bugs.webkit.org/show_bug.cgi?id=50999

Attachment 76844: Patch V0
https://bugs.webkit.org/attachment.cgi?id=76844&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
I have no knowledge to say r+, but this patch is not acceptable.

- We prefer inline functions to macros.
- We should add a test to Skipped file or test_expectations.txt if we know the
test will fail.
- unicode-variation-selector.html is not reviewable.

diff --git a/LayoutTests/fast/text/unicode-variation-selector.html
b/LayoutTests/fast/text/unicode-variation-selector.html
new file mode 100644
index
0000000000000000000000000000000000000000..473131a564f46aade7620ee06a06532c4fc58
35a
GIT binary patch
literal 1848


More information about the webkit-reviews mailing list