[webkit-reviews] review denied: [Bug 58905] [Qt][Texmap] Do not create a texture if it will not be used. : [Attachment 90215] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Young Han Lee
<joybro at company100.net>'s request for review:
Bug 58905: [Qt][Texmap] Do not create a texture if it will not be used.
https://bugs.webkit.org/show_bug.cgi?id=58905

Attachment 90215: Patch
https://bugs.webkit.org/attachment.cgi?id=90215&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=90215&action=review

Overall change looks good, r- to fix the typo and change come up with a better
function name.

> Source/WebCore/ChangeLog:14
> +	   No new tests required as no functionaliry changes.

Typo.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:176
> +    inline bool shouldBePainted() const

I think we should have a more descriptive name - what about haveContent() ?