[webkit-reviews] review denied: [Bug 57948] JSC bindings generator: support non-object numbers as callback arguments : [Attachment 88576] Patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 57948: JSC bindings generator: support non-object numbers as callback
arguments
https://bugs.webkit.org/show_bug.cgi?id=57948

Attachment 88576: Patch
https://bugs.webkit.org/attachment.cgi?id=88576&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88576&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2290
>> +			push(@implContent, "   
args.append(jsNumber(static_cast<$paramType>(${paramName})));\n");
> 
> Why the static_cast? The code should work fine, perhaps better, without it.

Indeed, the static_cast seems wrong in all places that its used so r- for that.
Please revise and resubmit.