[webkit-reviews] review granted: [Bug 59470] Prohibit the use of OwnPtr<T*> : [Attachment 91177] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 59470: Prohibit the use of OwnPtr<T*>
https://bugs.webkit.org/show_bug.cgi?id=59470

Attachment 91177: Patch
https://bugs.webkit.org/attachment.cgi?id=91177&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=91177&action=review

r=me

> Source/JavaScriptCore/wtf/OwnPtr.h:179
> +    template<typename T> class OwnPtr<T*> {
> +	   // Prevent usage as a real OwnPtr by not defining any functions.
> +    };
> +#endif

I believe you can do even better here by just using a declaration with no
definition.