[webkit-reviews] review denied: [Bug 56855] [GTK] Provide a way in DRT to check the platform name : [Attachment 88635] Patch proposal

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 56855: [GTK] Provide a way in DRT to check the platform name
https://bugs.webkit.org/show_bug.cgi?id=56855

Attachment 88635: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=88635&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88635&action=review

You should add a test that shows this is working. You should also explain why
this is needed.

> Tools/DumpRenderTree/LayoutTestController.cpp:2093
> +    return JSValueMakeString(context, controller->platformName());

This is leaking the JSStringRef returned by platformName. platformName should
return a JSRetainPtr<JSStringRef> instead.