[webkit-reviews] review denied: [Bug 57731] [CSS 3] missing cursor support for 'none' on Windows : [Attachment 88773] Updated patch including WebKit2

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Ryan <aikavanak at gmail.com>'s
request for review:
Bug 57731: [CSS 3] missing cursor support for 'none' on Windows
https://bugs.webkit.org/show_bug.cgi?id=57731

Attachment 88773: Updated patch including WebKit2
https://bugs.webkit.org/attachment.cgi?id=88773&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=88773&action=review

See Adam's suggestions in a previous comment. Further comments below. Please
revise and resubmit.

> Source/WebKit2/UIProcess/win/WebView.cpp:1011
> +    // It's ok if m_lastCursorSet is null:
> +    // that's how Cursor::None is represented.

This comment seems unnecessary, you don't have to explain the lack of a special
case.

> Source/WebKit2/UIProcess/win/WebView.cpp:1020
> +    // It's ok if m_webCoreCursor is null:
> +    // that's how Cursor::None is represented.

Also here. Particularly, having the comment a second time seems unnecessary,

> Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:800
> +    // It's ok if platformCursor is null:
> +    // that's how Cursor::None is represented.

And here too, I would drop the comment.