[webkit-reviews] review denied: [Bug 59472] Port Mozilla's IndexedDB tests: index cursors : [Attachment 91130] patch with changelog and layouttest

Tue Apr 26 16:28:18 PDT 2011

Tony Chang <tony at chromium.org> has denied Mark Pilgrim <pilgrim at chromium.org>'s
request for review:
Bug 59472: Port Mozilla's IndexedDB tests: index cursors
https://bugs.webkit.org/show_bug.cgi?id=59472

Attachment 91130: patch with changelog and layouttest
https://bugs.webkit.org/attachment.cgi?id=91130&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=91130&action=review

I suspect the bot will have a hard time landing these patches since the root of
the diff isn't the root of the webkit repo.

>
third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors-autoinc
rement.html:20
> +description("Test IndexedDB's index cursors");

Nit: Should this mention autoincrement (to help differentiate it from
object-cursors.html)?

>
third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/object-cursors.html:1
> +<!DOCTYPE html>

These tests look almost identical.  Can we make it into a single test file to
avoid the code repetition?