[webkit-reviews] review granted: [Bug 51941] refactor HTMLLinkElement to allow Link header implementation : [Attachment 78699] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Gavin Peters <gavinp at chromium.org>'s
request for review:
Bug 51941: refactor HTMLLinkElement to allow Link header implementation
https://bugs.webkit.org/show_bug.cgi?id=51941

Attachment 78699: Patch
https://bugs.webkit.org/attachment.cgi?id=78699&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78699&action=review

Ok.  I think it's time for this patch now.  Some minor nits below.

> Source/WebCore/html/HTMLLinkElement.h:76
> +    // from LinkLoaderClient

We don't really need this comment.

> Source/WebCore/loader/LinkLoaderClient.h:44
> +    virtual ~LinkLoaderClient();

Do we need this?  No one should be deleting subclasses via this pointer, right?


> Source/WebCore/loader/LinkLoaderClient.h:47
> +    virtual void linkLoaded();
> +    virtual void linkError();

It seems like these should be pure virtual.