[webkit-reviews] review granted: [Bug 59292] style-src should block inline style from <style> : [Attachment 90869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:15:23 PDT 2011


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 59292: style-src should block inline style from <style>
https://bugs.webkit.org/show_bug.cgi?id=59292

Attachment 90869: Patch
https://bugs.webkit.org/attachment.cgi?id=90869&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=90869&action=review

Seems reasonable though.

> Source/WebCore/dom/StyleElement.cpp:145
> +    if (document->contentSecurityPolicy()->allowInlineStyle()
> +	   && (type.isEmpty() || (e->isHTMLElement() ? equalIgnoringCase(type,
"text/css") : (type == "text/css")))) {

I would have probably made this a helper method.


More information about the webkit-reviews mailing list