[webkit-reviews] review denied: [Bug 56799] getMIMETypeForPath() should return the empty string by default so that it's usable in more places. : [Attachment 86417] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Andy Estes
<aestes at apple.com>'s request for review:
Bug 56799: getMIMETypeForPath() should return the empty string by default so
that it's usable in more places.
https://bugs.webkit.org/show_bug.cgi?id=56799

Attachment 86417: Patch
https://bugs.webkit.org/attachment.cgi?id=86417&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=86417&action=review

>>>> Source/WebCore/platform/network/FormData.cpp:235
>>>> +			  contentType = defaultMIMEType();
>>> 
>>> Doesn't this code run from a background thread? Calling a function that
returns a static local is not safe in that case.
>> 
>> Okay, maybe this needs to be kept as a string literal.
> 
> After looking into this I can't see where this code runs from a background
thread. This ends up getting called from an XMLHTTPRequest send() or a form
submit(), both of which seem to happen on the main thread. Just to be sure I
added ASSERT(isMainThread()) to the top of this method and none of the http
layout tests triggered the assertion.

I think Workers can trigger XMLHttpRequests.