[webkit-reviews] review denied: [Bug 57154] [Qt] Make OpenGL symbol resolver transparent : [Attachment 87496] clean ups

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 26 16:08:21 PDT 2011


Simon Hausmann <hausmann at webkit.org> has denied Jarkko Sakkinen
<jarkko.j.sakkinen at gmail.com>'s request for review:
Bug 57154: [Qt] Make OpenGL symbol resolver transparent
https://bugs.webkit.org/show_bug.cgi?id=57154

Attachment 87496: clean ups
https://bugs.webkit.org/attachment.cgi?id=87496&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
As a general direction I'd rather like to see us re-use
cairo/OpenGLShisms.cpp/h for example
and use opengl/GraphicsContext3DOpenGL.cpp and leave Qt specific bits in
GraphicsContext3DQt.cpp,
like the Gtk folks do.

On that note, why do we need to resolve the GL symbols at run-time?


More information about the webkit-reviews mailing list