[webkit-reviews] review denied: [Bug 29467] [Qt] QWebPage::findText() should allow to find text from the beginning : [Attachment 85356] Patch for review

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Aparna Nandyal
<aparna.nand at wipro.com>'s request for review:
Bug 29467: [Qt] QWebPage::findText() should allow to find text from the
beginning
https://bugs.webkit.org/show_bug.cgi?id=29467

Attachment 85356: Patch for review
https://bugs.webkit.org/attachment.cgi?id=85356&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=85356&action=review

> Source/WebKit/qt/Api/qwebpage.cpp:3587
> +	   if ((subString.isEmpty()) || (options & FindFromBeginning))	{

Style, two spaces before {

> Source/WebKit/qt/ChangeLog:5
> +	   [Qt] QWebPage::findText() should allow to find text from the
beginning

We should do this with a QWebElement-like API that exposes all nodes, not just
elements.
Please see the webkit-qt discussion about the topic.